From: Stefano Stabellini Date: Fri, 31 Mar 2017 22:37:07 +0000 (-0700) Subject: setup vwfi correctly on cpu0 X-Git-Tag: archive/raspbian/4.11.1-1+rpi1~1^2~66^2~2367 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=b32d442abd92cdd4d8f2a2e7794cfee9dba7fe22;p=xen.git setup vwfi correctly on cpu0 parse_vwfi runs after init_traps on cpu0, potentially resulting in the wrong HCR_EL2 for it. Secondary cpus boot after parse_vwfi, so in their case init_traps will write the correct set of flags to HCR_EL2. For cpu0, fix the issue by changing HCR_EL2 setting from a new presmp_initcall. Signed-off-by: Stefano Stabellini Reviewed-by: Julien Grall --- diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index 89a5f3b7c7..b7d5fb611e 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -117,6 +117,25 @@ static void __init parse_vwfi(const char *s) } custom_param("vwfi", parse_vwfi); +static int __init vwfi_init(void) +{ + /* + * HCR_EL2 has already been set on cpu0, change the setting here, if + * needed. Other cpus haven't booted yet, init_traps will setup + * HCR_EL2 correctly. + */ + if ( vwfi == NATIVE ) + { + register_t hcr; + + hcr = READ_SYSREG(HCR_EL2); + WRITE_SYSREG(hcr & ~(HCR_TWI|HCR_TWE), HCR_EL2); + } + + return 0; +} +presmp_initcall(vwfi_init); + void init_traps(void) { /* Setup Hyp vector base */